-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test instantiating biosamples from NCBI #149
Conversation
@pkalita-lbl have you worked on anything like this yet? I'm getting the Attributes for one NCBI Biosample here from the efetch API. We also have a Postgres version of the NCBI Biosample database on SPIN. |
There's some code in https://github.com/INCATools/biosample-analysis that tries to clean up some NCBI Biosample attributes. I don't think it uses nmdc-chema or submission-schema classes as its target. It was some of the earliest and worst code I wrote for BBOP. It might not be much use doing any more research in there. |
I don't know why the actions are saying
|
test with printing and minimal assertions
I have the sense that team members like @aclum and @sujaypatil96 are developing code for this in nmdc-runtime or other repos and I propose closing this PR |
Efforts of the current squad have been focused on nmdc biosamples -> ncbi samples + SRA records, not the other way around. |
@aclum @pkalita-lbl I am closing this PR now based on
|
Instantiating against
submission-schema
instead ofnmdc-schema
becausesubmission-schema
is already flat, like NCBI Biosample attributes.SoilInterface
(for example) that are unlikely to be asserted for NCBI Biosampleslat_lon
of '71.323 N 156.6114 W'